Repository navigation
Conversation
Match equivalent relative paths consistently while preserving parent components, directory markers and original input values in results. Add public matching API regressions and update the source changelog. Fixes cpburnz#176. Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
Owner
|
Thanks for finding and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
An anchored rule such as
/data/private.txtmissesdata//private.txtanddata/./private.txt, although Git recognizes all three paths as the same ignored file. Normalize redundant interior components before matching, preserving parent components, trailing directory markers and the original input values returned by the matching APIs.The regression coverage exercises
PathSpecandGitIgnoreSpec, positive and negated rules, batch and single-file results, custom separators and literal backslashes. Related #173 addresses repeated leading./prefixes.Validation on macOS ARM64:
git check-ignore; independent review also checked all three backends.Other Python/OS combinations remain for CI. The changelog source is updated; generated distribution documents were verified during the project's prebuild step.