Repository navigation
Fix negated root-only gitignore patterns - #180
Merged
cpburnz merged 4 commits intoNov 8, 2026
Merged
Conversation
Owner
|
Thanks for finding and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat
!/as a no-op, matching Git and the existing treatment of/.The root-only check currently runs before removing
!, so!/instead compiles to a directory negation. With['*', '!/', '!a/keep.txt'], that incorrectly reopensa/and permitsa/keep.txt. A real Git repository keeps the file ignored; bothgit check-ignoreand the index aftergit add -Aconfirm it.Move the root-only no-op check after negation processing. Leave
GitIgnoreBasicPatternunchanged because its/behavior is intentionally different.Regression coverage
/,!//, empty/comment patterns, actual!a/reinclusion and escaped\!/.Validation
On Linux, CPython 3.12.14:
git diff --checkpasses.This is a minimal reproducible correctness bug, not a claim of an observed production incident or its prevalence. Python 3.13.5 also ran the suite successfully, but without the optional backends (844 subtest skips). Other operating systems and upstream CI have not been verified here.
AI assistance disclosure: Codex performed the investigation, patch, tests and draft preparation, with independent automated verification of the Git reproduction, focused tests and full unittest suite. No human code review is claimed.