Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
copy.copy()reconstructs aRegexPatternthroughself.__class__(self.regex, self.include). This conflicts with the documented allowance for subclasses that do not acceptinclude: copying such a subclass raisesTypeError.For subclasses that do accept those arguments, their constructor runs again. Any additional dictionary or slot state is reset instead of being shallow-copied. For example, a metadata list attached to a pattern is silently replaced by an empty list.
Change
Remove the constructor-based
__copy__override and let Python's standard copy protocol preserve the object's dictionary and slots without rerunning its constructor. This retains the concrete subclass, original pattern, compiled regex and include flag. Add tests for the built-in pattern classes, compiled flags, subclasses withoutinclude, and subclass dictionary, private-slot and unset-slot state. Update the changelog.Validation
pathspec,tests/check_usage.pyand the new tests. Pyright passes for the same targets using the Python 3.14 environment.git diff --checkpass.Not verified: Windows/macOS, and the PyPy 3.11/3.12 Hyperscan environments. Those two environments lack prebuilt Hyperscan wheels here; their source builds did not complete within the local execution window. The base suites for both PyPy versions pass.