Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple backend called
pattern.match_file()for each pattern and file.RegexPattern.match_file()callsregex.search()and wraps the result in aRegexMatchResult. This change keeps the regex of each pattern in a list when the backend starts, and callsregex.search()directly. A pattern class that overridesmatch_file(), or a regex that is not are.Pattern, still usesmatch_file(). On PyPy, all patterns usematch_file(), because the direct call was up to 7% slower there. The results do not change.match_files()on the CPython source tree (5,614 files), with lines of its.gitignore:GitIgnoreSpec, 1 lineGitIgnoreSpec, 15 linesGitIgnoreSpec, 150 linesPathSpec, 1 linePathSpec, 15 linesPathSpec, 150 linesGitIgnoreSpec,*.py *.c *.h *.rst(most files match)Slowdown: the list costs about 55 ns for each pattern when a spec is created. Thus, to create a spec and match one file is up to 1.4% slower. On PyPy 3.11, no benchmark changed significantly.
I used 12 interleaved rounds and a Mann-Whitney test on 33 inputs (Apple M5). I did not measure other architectures.
Checks:
tox -e ci-base,ci-re2,ci-hyperscananddocspass.match_files(),check_files()andmatch_file()withstr,PathLikeand\separators, onGitIgnoreSpecandPathSpecwith all three backends.