Repository navigation
Store ready-queue links as pointers for Fil-C - #405
Merged
Merged
Conversation
…rs in the LLVM IR.
|
An automated preview of the documentation is available at https://405.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-23 02:00:06 UTC |
|
GCOVR code coverage report https://405.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-10-23 02:17:50 UTC |
Benchmark report
linux — full results (226 benchmarks, 5 iterations, 1.5s each)accept_churn
fan_out
http_server
local_socket_latency
local_socket_throughput
socket_latency
socket_throughput
windows — full results (77 benchmarks, 5 iterations, 1.5s each)accept_churn
fan_out
http_server
socket_latency
socket_throughput
macos — full results (113 benchmarks, 5 iterations, 1.5s each)accept_churn
fan_out
http_server
local_socket_latency
local_socket_throughput
socket_latency
socket_throughput
Run & raw JSON artifacts · flag rule: |median Δ| > max(2%, 3×CV of the noisier side) · advisory only |
sgerbino
requested changes
Oct 22, 2026
Collaborator
There was a problem hiding this comment.
We should add // NOLINT(performance-no-int-to-ptr) where necessary so clang-tidy passes.
Also, there some places where we compare the old uintptr_t to 0 which should change to a nullptr check.
corosio/test/unit/ready_queue.cpp
Line 47 in 524bcdc
corosio/test/unit/ready_queue.cpp
Line 83 in 524bcdc
Thank you for the contribution!
Collaborator
|
The clang-tidy silence didn't work correctly, maybe because it's multi-line. |
Contributor
Author
I'll take another shot at this. |
sgerbino
approved these changes
Oct 23, 2026
sgerbino
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs in the LLVM IR.
In the non-Fil-c case, I would expect these changes to make no difference in the generated code.
I would expect these changes to work for CHERI and CHERIoT systems as well, but I have not tested on those platforms.