fix: conversion functions are named as written - #1263
Open
gennaroprota wants to merge 1 commit into
Open
Conversation
✨ Highlights
🧾 Changes by Scope
🔝 Top Files
|
This fixes an issue for which `operator CArray&` came out as `operator &`, `operator T::type` as `operator ::type`, and `operator fun_ptr` as `operator void(*)()`. The empty names also collided, so conversions to unrelated types were grouped as overloads of each other. Furthermore, a using-declaration that imports a conversion is named the same way now. Fixes cppalliance#1259.
gennaroprota
force-pushed
the
fix/conversion_operator_names
branch
from
August 25, 2026 15:16
5dd56dc to
ebde394
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1263 +/- ##
========================================
Coverage 83.12% 83.12%
========================================
Files 35 35
Lines 3662 3662
Branches 844 844
========================================
Hits 3044 3044
Misses 410 410
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1263.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-08-25 15:23:30 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue for which
operator CArray&came out asoperator &,operator T::typeasoperator ::type, andoperator fun_ptrasoperator void(*)().The empty names also collided, so conversions to unrelated types were grouped as overloads of each other.
Furthermore, a using-declaration that imports a conversion is named the same way now.
Fixes #1259.
Changes
ASTVisitornames a conversion function after the conversion type as written instead of after theDeclarationName.operatorinstead ofoperator Uand an imported conversion withvoid(*)()in it, rather thanfun_ptr).Testing
The new fixture is covered by the existing golden suite.
Documentation
No documentation change.