Fix #14891 FP knownConditionTrueFalse (dereferencing pointer to array member)

[chrchr-github]

No description provided.

[chrchr-github]

@pfultz2 Please review, I'm not entirely sure this is the right fix.

[pfultz2]

Yea this is not the right fix. The correct fix should be in valueFlowSymbolic. There are a couple of issue here.

First const int* p = a should not create a symbolic value. We have checks in valueFlowSymbolic for different types and implicit conversions and it needs to be updated to skip for decaying arrays as well.

Secondly, the lifetime of p shows lifetime[Object]=(a) but it would be better if it was lifetime[Address]=(a). Its probably not necessary to fix for this FP, but its something I noticed with the valueflow output.