Add comprehensive test and CI coverage#159
Open
xusheng6 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
review/auth.pyWhy
The previous tests were stale in several places, accepted ambiguous outcomes, and could not reliably exercise authenticated workflows without production users or configuration. Reviewer and onsite-writeup paths also lacked sufficient integration coverage.
These changes give CI disposable users and databases, exact behavioral assertions, real-MongoDB validation, and broad coverage of important success, authorization, validation, rollback, and failure paths without browser automation.
Additional fix
The expanded tests found that a malformed
Nonepassword hash raisedAttributeError. Password matching now fails closed and returnsFalsefor that case.Validation
194 passedgit diff --checkpasses