Skip to content

fix(ci): satisfy zizmor in features.yml (DF-S) - #26

Merged
crazyracer98 merged 1 commit into
mainfrom
wip/DF-S
Oct 31, 2026
Merged

crazyracer98 merged 1 commit into
mainfrom
wip/DF-S

Conversation

@crazyracer98

Copy link
Copy Markdown
Contributor

Prepares features.yml for template-base v1.14.x scanners (zizmor).

  • artipacked: the docs job's checkout sets persist-credentials: false; the token is handed to the git ls-remote/push calls only, as a masked http extraheader. gh uses GH_TOKEN as before.
  • dangerous-triggers: line-level zizmor ignore on workflow_run. Reasoning is in the comment: the docs job's if: guards (lines 238-245: release.yml path, workflow_dispatch event, success, main, same repository) make the checked-out head_sha trusted main code, and head_sha reaches the shell only via env. If those guards are loosened, the ignore must go.
  • adhoc-packages: ignore on both npm installs; the version is exact-pinned via DEVCONTAINER_CLI_VERSION (0.89.0, bumped by Renovate together with scripts/develop.d/10-devcontainer-cli.sh).

The gitleaks allowlist for the CLI_KEYCLOAK/CLI_VALKEY sha256 pins goes into .gitleaks.toml on the v1.14.x sync PR, because that file and its manifest tier only arrive with the sync.

…rs, adhoc-packages) (DF-S)

- docs checkout: persist-credentials false; the token goes to the git calls that talk to the remote only, as an extraheader

- workflow_run: zizmor ignore[dangerous-triggers] with the guard reasoning

- npm install of @devcontainers/cli: ignore[adhoc-packages], exact-pinned via env
@crazyracer98
crazyracer98 merged commit 5337983 into main Oct 31, 2026
86 checks passed
@crazyracer98
crazyracer98 deleted the wip/DF-S branch October 31, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant