Repository navigation
Fix mimalloc download - #1250
Merged
Merged
Conversation
dunglas
force-pushed
the
fix/github-pagination
branch
from
October 10, 2026 15:46
100238f to
d7a8df8
Compare
dunglas
changed the title
dunglas
force-pushed
the
fix/github-pagination
branch
from
October 10, 2026 15:51
d7a8df8 to
70a96c4
Compare
dunglas
changed the title
dunglas
changed the title
henderkes
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the mimalloc download, which currently fails with:
The GitHub tags API returns 30 tags per page by default. microsoft/mimalloc now has more than 30
v3.xtags, so nov2.xtag is left on the first page for thematchpattern to find. Requesting 100 tags per page brings them back, the same wayext-httpandext-raphfalready do. With this change,bin/spc download mimallocfetches v2.5.2.Found while moving FrankenPHP's static builds to v3: php/frankenphp#2618
Checklist before merging
*.phpor*.yml, run them locally to ensure your changes are valid:composer cs-fix(no PHP changes)composer analyse(no PHP changes)composer test(no PHP changes)bin/spc dev:lint-config(only flagsconfig/pkg/lib/lcms2.yml, which is already unsorted onv3)