fix(renovate): match ARG GO_VERSION in Dockerfile - #341
Merged
Conversation
The Dockerfile half of the Go custom manager never produced a dependency. Renovate compiles matchStrings with the 'g' flag only, so the leading '^' anchored to the start of the file rather than the start of a line, and the ARG sits a few lines down. Even on a match, the lazy group had nothing following it and would have captured the empty string. Drop the anchor and terminate on a newline, as the sibling GO_VERSION pattern already does. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
phisco
requested review from
negz,
sergenyalcin,
turkenf and
ulucinar
as code owners
August 6, 2026 12:38
sergenyalcin
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The Dockerfile half of the Go custom manager added in #338 never produced a dependency. Renovate compiles
matchStringswith thegflag only (regEx(matchString, 'g')inlib/modules/manager/custom/regex/strategies.ts), so the leading^anchored to the start of the file rather than the start of a line, andARG GO_VERSION=sits a few lines down. Even on a match the lazy group had nothing following it, so it would have captured the empty string.This drops the anchor and terminates on a newline, as the sibling
GO_VERSION:pattern already does. Verified against this repo's Dockerfile with thegflag: the old pattern yields 0 matches, the new one captures1.Heads-up for reviewers: this makes the manager live, so Renovate will start proposing Go bumps for the Dockerfile ARG. Here the ARG is
1, so expect a PR proposing a concrete version — if keeping the floating major is deliberate, this repo wants anignorerule rather than the matcher staying broken.I have:
Added or updated unit tests for my change.(renovate configuration only)