Repository navigation
fix: preserve legacy delivery history during upgrades - #1441
Merged
Merged
Conversation
Deploying edgewatch with
|
| Latest commit: |
df6d2d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a977757d.edgewatch-cpd.pages.dev |
| Branch Preview URL: | https://fix-upgrade-restore-safety-1.edgewatch-cpd.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema upgrades leave sent delivery history byte for byte unchanged, and restores distinguish genuinely pending deliveries from rows exhausted under the pre-schema-63 retry budget. Restore policy evaluation carries the source schema version, so valid legacy exhausted rows remain terminal instead of being quarantined or discarded as pending.
The schema-54 fixture applies each migration in its own bounded transaction and checks the WAL after every step. It includes 5,000 sent rows with 4,063-byte payloads (~20.3 MB); the largest measured per-step WAL was 115,392 bytes against a 16 MiB limit. Restore coverage starts from schema 54 and 62 across quarantine, discard, and preserve policies; it checks pending-row policy behavior, byte-identical sent history, and that the same exhausted managed row appears in
ListTerminalDeliveriesafter restore.Closes #1386
Closes #1401
Closes #1428
Validation on exact PR head
df6d2d606820fcad03cf8c2cfc9ce9a39a399622:store-1,store-2,store-3, andotherall passed; the aggregate gate passed at 88.6% across 17 production packages.28eb02a1f602fc484fbe221c6bd8fb5e835d9418.go vet ./...,make security, schema-doc checks, and the docs build passed. The schema-54 baseline statements, rows, and frozen migration-chain golden were not changed.Merged-main CI run 38431394474, documentation run 38431394420, and Pages deployment run 38431395674 all completed successfully at merge
2f51e140e8797db2e5d6cfa17fb52aade1cb1c04.