Repository navigation
docs(ocm): clarify contact removal semantics - #426
Conversation
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
e0a3810 to
3a2b594
Compare
|
To be honest I'm a bit lost with this PR: there are parts that surely are missing and should be merged, but quite many rewritten sections appear to me not very useful, as they make the text longer and more verbose without adding any content - which is typical of LLM-generated text. I'll try and go for a detailed review soon, not today though! |
|
@glpatcern yes true, I wanted to open the PR so Micke and you can see it before working on it more since I almost started working on it from 3rd Nov, and then rebased it a couple time, now I can clean it up and make it properly ready. The idea I had was written and merged by you in the previous PR and this one is here to address the rest of it. |
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Yes, I see the intent and you were right to push it out. I've added comments to many sections, the general comment I have is this needs to be split, and the specific contact removal IMHO can be greatly simplified.
3a2b594 to
4e1cef7
Compare
|
I have fixed this pr to be in scope of its title Will open new ones soon to address the other parts of the specification |
This PR is part of cs3org/OCM-STA#57.
Summary
Keep contact removal limited to the two users involved and preserve existing shares unless separately withdrawn or declined. Distinguish it from user and group departure, and add CONTACT_REMOVED to the notification registry.