Skip to content

fix: preserve ancestor selectors for literal ampersands #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainmenke merged 1 commit into from
Oct 10, 2026
Merged

fix: preserve ancestor selectors for literal ampersands #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ module.exports = function resolveNestedSelector(selector, node) {
var parentSelectors = (parentIsNestAtRule)
? split(parent.params, ',', false).map((x) => x.trim())
: parent.selectors;
var selectorParts = split(selector, '&', true);

var resolvedSelectors = parentSelectors.reduce(function(result, parentSelector) {
if (selector.indexOf('&') !== -1) {
if (selectorParts.length > 1) {
var newlyResolvedSelectors = resolveNestedSelector(parentSelector, parent).map(function(resolvedParentSelector) {
return split(selector, '&', true).join(resolvedParentSelector);
return selectorParts.join(resolvedParentSelector);
});
return result.concat(newlyResolvedSelectors);
}
Expand Down
10 changes: 10 additions & 0 deletions test/api.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@ import test from 'node:test';
import assert from 'node:assert/strict';
import util from './util.mjs';

for (const selector of ['[data-label="&"]', String.raw`.\&`, ':is([data-label="&"])']) {
test(`preserves ancestor selectors when ${selector} has only literal ampersands`, async () => {
const code = `.outer { .parent { ${selector} { color: red } } }`;
assert.deepEqual(
await util.resolveChosenSelector(code, selector),
[`.outer .parent ${selector}`],
);
});
}

test(async t => {
const code = `a { b { top: 0; c { d {}}}}`;
assert.deepEqual(
Expand Down
Loading