Repository navigation
[feat] intercept swap-unsupported data type commands - #456
Merged
Merged
Conversation
qiongtubao
force-pushed
the
feat/swap-unsupport-cmd
branch
3 times, most recently
from
September 30, 2026 03:50
7569361 to
cf4f96f
Compare
qiongtubao
force-pushed
the
feat/swap-unsupport-cmd
branch
4 times, most recently
from
October 13, 2026 08:00
e24eb83 to
85c416b
Compare
stream commands (XADD, XREADGROUP, XGROUP, XSETID, XACK, XCLAIM, XAUTOCLAIM, XDEL, XTRIM) operate on data types that swap does not support. Add a flag-based mechanism to intercept and count these commands with an operator-controlled opt-in switch. Flags (CMD_SWAP_HARD_BLOCKED, CMD_SWAP_OPT_IN) are parsed from sflags and recognized by module flags. Counters are exposed via swap.info output. Master propagates opt-in setting via swap.info. A swap.debug reset-cmd-stats command clears the counters. A new unit test (swap/unit/swap_unsupport_cmd) covers opt-in on/off, counter increment, reset, and swap.info output.
qiongtubao
force-pushed
the
feat/swap-unsupport-cmd
branch
from
October 13, 2026 08:47
85c416b to
24e6085
Compare
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream commands (XADD, XREADGROUP, XGROUP, XSETID, XACK, XCLAIM, XAUTOCLAIM, XDEL, XTRIM) operate on data types that swap does not support. Add a flag-based mechanism to intercept and count these commands with an operator-controlled opt-in switch.
Flags (CMD_SWAP_HARD_BLOCKED, CMD_SWAP_OPT_IN) are parsed from sflags and recognized by module flags. Counters are exposed via swap.info output. Master propagates opt-in setting via swap.info.
A swap.debug reset-cmd-stats command clears the counters. A new unit test (swap/unit/swap_unsupport_cmd) covers opt-in on/off, counter increment, reset, and swap.info output.