Upstream 2116 - Use the web supervisord config in the web liveness probe - #23
Open
blaipr wants to merge 1 commit into
Open
Upstream 2116 - Use the web supervisord config in the web liveness probe#23blaipr wants to merge 1 commit into
blaipr wants to merge 1 commit into
Conversation
The web deployment's liveness probe invoked supervisorctl against /etc/supervisord_task.conf, the task pod's configuration, so it reported on the task process group rather than the web one. Ports ansible/awx-operator#2116.
blaipr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: ansible/awx-operator#2116
SUMMARY
The web deployment's liveness probe runs
supervisorctlagainst/etc/supervisord_task.conf:That is the task pod's configuration — the line is byte-identical to the one in
task.yaml.j2. The web pod's liveness probe therefore reports on the task process group instead of its own, so a web pod whose own processes have stopped can still pass its liveness check.Confirmed the target path is valid for the Ascender images:
tools/ansible/roles/dockerfile/templates/Dockerfile.j2in ctrliq/ascender installssupervisor_web.confto/etc/supervisord_web.conf.Not present in this fork.
ISSUE TYPE
COMPONENT NAME