Upstream 2106 - Add use_db_compression for backup database dumps - #28
Open
blaipr wants to merge 1 commit into
Open
Upstream 2106 - Add use_db_compression for backup database dumps#28blaipr wants to merge 1 commit into
blaipr wants to merge 1 commit into
Conversation
Adds a use_db_compression field to AWXBackup. It defaults to true, which renders the pg_dump command unchanged; setting it false appends -Z 0 to trade backup size for CPU time on the database pod. Ports ansible/awx-operator#2106.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: ansible/awx-operator#2106
SUMMARY
Adds a
use_db_compressionfield to theAWXBackupCRD, controllingpg_dump's built-in compression:Backward compatible. The field defaults to
true, which renders an empty string into the command, so the generatedpg_dumpis byte-identical to today's. Setting itfalseappends-Z 0, trading backup size for CPU time on the database pod — useful where the dump is already compressed downstream, or where the pod is CPU-constrained.Cherry-picked cleanly from upstream; not present in this fork. Includes the CRD field and the matching CSV
specDescriptorsentry.ISSUE TYPE
COMPONENT NAME