[CLK 6.18] spec: Enable Rocky 10 builds - #1526
Open
bmastbergen wants to merge 2 commits into
Open
Conversation
Replace the hardcoded el_version with %{rhel} directly, which is set
automatically by the buildroot. This allows the same branch to produce
el9 packages in a Rocky 9 mock and el10 packages in a Rocky 10 mock.
Update generate_tarball.sh to accept the el version as an optional CLI
argument (e.g. ./generate_tarball.sh 10), falling back to rpm --eval
'%{rhel}' when not specified.
On Rocky 10, use the system bindgen-cli package (available in CRB)
instead of building from the bundled source tarball.
Extend the RPM Build CI workflow to validate builds for both Rocky 9
and Rocky 10 by adding el_version as a matrix dimension.
GCC 14 enforces named address space checking for percpu pointers (__seg_gs on x86_64). local_unlock() expands through this_cpu_ptr(), which requires a __percpu pointer argument. The devrandom code in lock_default_rng() correctly acquires the local lock using the percpu pointer pcri, but the unlock paths used the already-dereferenced cri pointer instead. Fix by using the percpu pointer for all local_unlock() calls
bmastbergen
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec: use %{rhel} for el version and conditionally use system bindgen
Replace the hardcoded el_version with %{rhel} directly, which is set
automatically by the buildroot. This allows the same branch to produce
el9 packages in a Rocky 9 mock and el10 packages in a Rocky 10 mock.
Update generate_tarball.sh to accept the el version as an optional CLI
argument (e.g. ./generate_tarball.sh 10), falling back to rpm --eval
'%{rhel}' when not specified.
On Rocky 10, use the system bindgen-cli package (available in CRB)
instead of building from the bundled source tarball.
Extend the RPM Build CI workflow to validate builds for both Rocky 9
and Rocky 10 by adding el_version as a matrix dimension.
crypto: rng: fix local_unlock() with non-percpu pointer for GCC 14
GCC 14 enforces named address space checking for percpu pointers
(__seg_gs on x86_64). local_unlock() expands through this_cpu_ptr(),
which requires a __percpu pointer argument.
The devrandom code in lock_default_rng() correctly acquires the
local lock using the percpu pointer pcri, but the unlock paths used the
already-dereferenced cri pointer instead.
Fix by using the percpu pointer for all local_unlock() calls