Repository navigation
chore(deps): bump webpki-roots to 1.0.10 and rustls-webpki to 0.103.16 - #12378
Merged
Merged
Conversation
Pulls the upstream distrust of the compromised eMudhra (emSign) intermediates into every Rust tree. Lockfile-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Claude finished @bsod90's task in 1m 12s —— View job LGTM, no issues found (0 high, 0 medium, 0 low) Review details
What I checked
Review threadsThe listing returned 0 of my own threads, so there was nothing to resolve or re-affirm. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12378 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 525 525
Lines 121408 121408
Branches 5136 5136
=======================================
Hits 100476 100476
Misses 20163 20163
Partials 769 769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ovr
approved these changes
Oct 22, 2026
2 of 4 tasks
ovr
added a commit
that referenced
this pull request
Oct 23, 2026
…6 (v1.6) Backport of #12378 to lts/v1.6. rustls 0.23.11 on this branch still depends on rustls-webpki 0.102, so rustls is moved to 0.23.35 (same version as master) to pick up 0.103.16. Co-authored-by: Maxim <maxim@cube.dev> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ovr
added a commit
that referenced
this pull request
Oct 23, 2026
…6 (v1.6) Backport of #12378 to lts/v1.6. rustls 0.23.11 on this branch still depends on rustls-webpki 0.102, so rustls is moved to 0.23.35 (same version as master) to pick up 0.103.16. Co-authored-by: Maxim <maxim@cube.dev> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ovr
added a commit
that referenced
this pull request
Oct 23, 2026
…v1.6) (#12398) Backport of #12378 to lts/v1.6. eMudhra (emSign) intermediate CA keys were compromised: webpki-roots 1.0.10 drops the emSign roots and rustls-webpki 0.103.16 rejects chains containing the distrusted keys. Lockfile-only. Unlike master, rustls 0.23.x on this branch still depended on rustls-webpki 0.102, so rustls moves to 0.23.35 (the version on master), also pulling rustls-pki-types 1.15.1 (and zeroize 1.9.1 in Cube Store). | Lockfile | rustls | rustls-webpki | webpki-roots | |---|---|---|---| | rust/cubestore | 0.23.7 → 0.23.35 | 0.102.2 → 0.103.16 | 0.26.1 → 0.26.11 + 1.0.10 | | rust/cubesql | 0.23.11 → 0.23.35 | 0.102.5 → 0.103.16 | 0.26.3 → 0.26.11 + 1.0.10 | | packages/cubejs-backend-native | 0.23.11 → 0.23.35 | 0.102.5 → 0.103.16 | 0.26.3 → 0.26.11 + 1.0.10 | | rust/cube | — | 0.103.13 → 0.103.16 | 1.0.7 → 1.0.10 | Co-authored-by: Maxim <maxim@cube.dev> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eMudhra (emSign) intermediate CA keys were compromised; the rustls stack now refuses them.
webpki-roots1.0.10 drops the emSign roots (rustls/webpki-roots@c644e3e) andrustls-webpki0.103.16 rejects any chain containing the distrusted intermediate keys (rustls/webpki#546). The Node side was fixed by the Node 24.22.1 bump in v1.8.10; the Rust lockfiles were not touched there.Lockfile-only.
webpki-roots0.26.11 is the compatibility shim that re-exports 1.x, so moving the 0.26 copies to it pulls 1.0.10 without bumpingreqwest/hyper-rustls.webpki-rootsrustls-webpkirust/cubestorerust/cubesqlpackages/cubejs-backend-nativerust/cuberust/cube-cliNo other packages move.
webpki-root-certsis not in any tree. Cube Store's S3/GCS remote FS uses native-tls (the image's system CA store), so it is unaffected by this change.cargo check --lockedpasses inrust/cubesql(--all-targets),rust/cube,rust/cube-cliandpackages/cubejs-backend-native. Inrust/cubestorethe TLS crates compile locally, but the full check stops at a macOS-onlylibrdkafkalink error, so CI is the check there.Check List
🤖 Generated with Claude Code