Skip to content

feat: store all test steps in ClickHouse and remove the steps rollout values [ENG-2245] - #84

Draft
agoldis wants to merge 1 commit into
mainfrom
agoldis/steps-clickhouse-only
Draft

agoldis wants to merge 1 commit into
mainfrom
agoldis/steps-clickhouse-only

Conversation

@agoldis

@agoldis agoldis commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Owner: @agoldis
Linear: ENG-2245

Merge with the on-prem release that includes https://github.com/currents-dev/currents/pull/5214. Before those images, removing the values does nothing harmful, but the docs and changelog describe behavior the older images don't have.

What and why

With images that include #5214, every install stores test steps in ClickHouse (test_attempt_steps). The images no longer read STEPS_CLICKHOUSE_DUAL_WRITE_FROM or STEPS_CLICKHOUSE_ONLY_FROM, and no longer read steps from object storage or MongoDB.

  • Removes currents.testSteps.dualWriteFrom and currents.testSteps.onlyFrom, the currents.testStepsEnv helper and its env entries on director and writer. A values file that still sets them renders the same manifests, because Helm ignores unknown values.
  • Keeps currents.testSteps.retentionDays (STEPS_RETENTION_DAYS on writer), unchanged.
  • Rewrites the quickstart section "Test Steps in ClickHouse": which services must reach ClickHouse and what breaks if they don't, retention, and that steps stored by earlier images don't show. The opt-in, rollout and going-back steps are gone. The anchor changes from #test-steps-in-clickhouse-optional to #test-steps-in-clickhouse; all links are updated.
  • Replaces the Unreleased changelog entry with upgrade notes. docs/configuration.md is regenerated with ./scripts/build-docs.sh.

The two values were added in #81 and never shipped in a released chart, so the changelog doesn't tell anyone to remove them. It does tell installs that set the env vars by hand in global.env or a service's env to remove them. No chart version bump; the release PR does that.

Checks

  • helm lint charts/currents -f charts/currents/ci/lint-values.yaml (helm 3.16.4 in Docker): passed.
  • helm template with default values: identical to main.
  • helm template with onlyFrom and retentionDays=30 set: only STEPS_RETENTION_DAYS: "30" on writer; no STEPS_CLICKHOUSE_* anywhere.
  • helm-docs (Docker, as in the docs check workflow): only the testSteps rows changed.
  • Not run: ct install (CI does it).

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

… values [ENG-2245]

Images that include currents-dev/currents#5214 always store test steps
in ClickHouse and no longer read STEPS_CLICKHOUSE_DUAL_WRITE_FROM or
STEPS_CLICKHOUSE_ONLY_FROM. currents.testSteps.dualWriteFrom and
onlyFrom set nothing the images read, so they are removed with the
env entries on the director and the writer. retentionDays stays.

The quickstart section describes what must reach ClickHouse and that
steps stored in object storage or MongoDB by earlier images no longer
show. The changelog gets the upgrade notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@baz-reviewer

baz-reviewer Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Remove the ClickHouse rollout configuration from the Currents Helm chart while preserving currents.testSteps.retentionDays, so installations use ClickHouse-only test-step storage. Update quickstart, configuration, and changelog guidance to document connectivity requirements, retention, and the loss of steps stored by earlier images.

Topics

TopicDetails
Update operator guidance Rewrite deployment guidance for ClickHouse-only steps, including required service connectivity, retention behavior, upgrade impact, and removal of obsolete rollout instructions.
Modified files (2)
  • CHANGELOG.md
  • docs/eks/quickstart.md
Latest Contributors(2)
UserCommitDate
agoldis@gmail.comfeat: store all test s...November 19, 2026
agoldis@users.noreply....feat: add values to tu...November 17, 2026
Simplify step storage Remove dualWriteFrom, onlyFrom, and their STEPS_CLICKHOUSE_* environment variables from Helm templates and values while retaining writer retention configuration.
Modified files (5)
  • charts/currents/templates/_common.tpl
  • charts/currents/templates/director/deployment.yaml
  • charts/currents/templates/writer/deployment.yaml
  • charts/currents/values.yaml
  • docs/configuration.md
Latest Contributors(2)
UserCommitDate
agoldis@gmail.comfeat: store all test s...November 19, 2026
agoldis@users.noreply....feat: add values to tu...November 17, 2026


Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant