Repository navigation
Conversation
… values [ENG-2245] Images that include currents-dev/currents#5214 always store test steps in ClickHouse and no longer read STEPS_CLICKHOUSE_DUAL_WRITE_FROM or STEPS_CLICKHOUSE_ONLY_FROM. currents.testSteps.dualWriteFrom and onlyFrom set nothing the images read, so they are removed with the env entries on the director and the writer. retentionDays stays. The quickstart section describes what must reach ClickHouse and that steps stored in object storage or MongoDB by earlier images no longer show. The changelog gets the upgrade notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| Topic | Details | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Update operator guidance | Rewrite deployment guidance for ClickHouse-only steps, including required service connectivity, retention behavior, upgrade impact, and removal of obsolete rollout instructions.Modified files (2)
Latest Contributors(2)
| |||||||||
| Simplify step storage | Remove dualWriteFrom, onlyFrom, and their STEPS_CLICKHOUSE_* environment variables from Helm templates and values while retaining writer retention configuration.Modified files (5)
Latest Contributors(2)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: @agoldis
Linear: ENG-2245
Merge with the on-prem release that includes https://github.com/currents-dev/currents/pull/5214. Before those images, removing the values does nothing harmful, but the docs and changelog describe behavior the older images don't have.
What and why
With images that include #5214, every install stores test steps in ClickHouse (
test_attempt_steps). The images no longer readSTEPS_CLICKHOUSE_DUAL_WRITE_FROMorSTEPS_CLICKHOUSE_ONLY_FROM, and no longer read steps from object storage or MongoDB.currents.testSteps.dualWriteFromandcurrents.testSteps.onlyFrom, thecurrents.testStepsEnvhelper and its env entries ondirectorandwriter. A values file that still sets them renders the same manifests, because Helm ignores unknown values.currents.testSteps.retentionDays(STEPS_RETENTION_DAYSonwriter), unchanged.#test-steps-in-clickhouse-optionalto#test-steps-in-clickhouse; all links are updated.docs/configuration.mdis regenerated with./scripts/build-docs.sh.The two values were added in #81 and never shipped in a released chart, so the changelog doesn't tell anyone to remove them. It does tell installs that set the env vars by hand in
global.envor a service'senvto remove them. No chart version bump; the release PR does that.Checks
helm lint charts/currents -f charts/currents/ci/lint-values.yaml(helm 3.16.4 in Docker): passed.helm templatewith default values: identical tomain.helm templatewithonlyFromandretentionDays=30set: onlySTEPS_RETENTION_DAYS: "30"onwriter; noSTEPS_CLICKHOUSE_*anywhere.helm-docs(Docker, as in the docs check workflow): only thetestStepsrows changed.ct install(CI does it).🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.