Repository navigation
Fix Vercel builds: Node.js 24 and a lighter plugin list - #455
Merged
Merged
Conversation
Vercel discontinued Node.js 20, which the cursor-directory project is still set to, so every deployment since September has failed right after cloning. engines.node in the app's package.json overrides the project setting. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The homepage, plugin static params and sitemap all loaded every active
plugin with select('*, plugin_components(*)'): about 69 MB over 53
requests, since the production Data API returns at most 100 rows per
request. That took longer than the cache-fill limit while prerendering
the homepage, so builds failed with USE_CACHE_TIMEOUT.
getPluginListing selects only the plugin columns those three use (about
3 MB) and orders by id as a tiebreaker so pages can't skip or repeat
rows.
Co-authored-by: Cursor <cursoragent@cursor.com>
ericzakariasson
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Vercel deployment since September has failed, including the #434 merge on
main, so production is still on the June 9 build. This fixes the two causes. The preview deploy for this PR is the first successful build since June.cursor-directoryproject is still set to 20.x, so builds stopped seconds after cloning. Settingengines.nodeto24.xinapps/cursor/package.json(the project's root directory) overrides the project setting, so the change doesn't need Vercel admin access.USE_CACHE_TIMEOUT). The homepage, the plugin pages' static params, and the sitemap all loaded every active plugin withselect('*, plugin_components(*)'). That's about 69 MB over 53 requests, because the production Data API returns at most 100 rows per request. The newgetPluginListingselects only the plugin columns those three use (about 3 MB) and addsidas a sort tiebreaker so pages can't skip or repeat rows. It replacesgetPlugins, which had no other callers.Production's 100-row cap also truncates the existing
fetchAllPagescallers that use the default 1,000-row page size (getCompanies,getRuleRedirectSlugs). That's left for a follow-up because fixing it changes what the build prerenders.Testing
bunx biome ci .andbun run typecheckpass.