Repository navigation
X skill: ask about remembering the Chat key as a separate question - #542
Merged
vaulpannx merged 1 commit intoOct 11, 2026
Merged
Conversation
The PIN secret-request only has a masked field, so a remember question inside that card never gets an answer. Send a Yes/No question widget alongside it and add --remember-key only on a clear Yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Chat PIN card only has a masked field, so asking whether to remember the X Chat key inside that card never gets an answer and the agent was defaulting to no. The skill now sends a separate Yes/No question widget alongside the PIN request and adds
--remember-keyonly on a clear Yes. Bumps the X plugin to 2.6.1.Note
Low Risk
Documentation and agent-skill guidance only; no runtime helper or MCP code changes.
Overview
Fixes X Chat “remember key” flow so agents can actually capture the user’s choice when a PIN is required. The masked PIN card couldn’t answer an inline remember prompt, so the skill now requires a separate Yes/No question widget next to the secret PIN request—not in the PIN card description—and waits for an explicit answer before
unlock-check.--remember-keyis passed only on a clear Yes; No leaves the key unsaved, with no default. Session bootstrap step 7 is aligned with that behavior. Plugin version is bumped to 2.6.1 with a matching changelog entry.Reviewed by Cursor Bugbot for commit 3f2474f. Bugbot is set up for automated code reviews on this repo. Configure here.