Skip to content

Upstream nightly v0.1.4-nightly.20261028.3841: make it merge and build on custom-nightly #188

Closed

Description

@github-actions

Upstream nightly v0.1.4-nightly.20261028.3841 from main does not yet merge and build on custom-nightly, so no custom build is published. Chamaquita fixes it and, because this issue carries automerge, merges her pull request once its checks pass.

Base branch: custom-nightly
Job branch: chamaquita/upstream-v0.1.4-nightly.20261028.3841
Upstream tag: v0.1.4-nightly.20261028.3841 from https://github.com/pingdotgg/t3code.git

Merging it stopped on conflicts in:

  • apps/server/src/settingsSecrets.ts

Task

  1. Start chamaquita/upstream-v0.1.4-nightly.20261028.3841 from origin/custom-nightly, or continue it if an earlier attempt pushed it. If git merge-base --is-ancestor v0.1.4-nightly.20261028.3841 HEAD fails, fetch the tag with git fetch --no-tags https://github.com/pingdotgg/t3code.git tag v0.1.4-nightly.20261028.3841 and merge it with git merge --no-ff v0.1.4-nightly.20261028.3841. Never rebase, squash, or cherry-pick: the nightly decides what is merged with that ancestor check, so only a merge commit keeps the tag an ancestor.
  2. Resolve each conflicted hunk:
    • Classify it as disjoint (the sides changed different things, so keep both), same question with different answers (pick one side on the evidence), or superseded (one side's change makes the other's moot).
    • Touch only the conflicted regions, and leave every line git merged cleanly as it is.
    • Keep the fork's customizations and take upstream's changes. The fork's intent is in git log v0.1.4-nightly.20261028.3841..origin/custom-nightly; upstream's is in git log origin/custom-nightly..v0.1.4-nightly.20261028.3841 and its pull requests.
    • Take upstream's pnpm-lock.yaml and run pnpm install --ignore-scripts to reconcile it with the merged manifests.
  3. Fix whatever stops it building. Upstream moves and renames code without conflicts, so adapt the fork's code to upstream's changes rather than editing upstream files. If the failure is not in the code, such as a missing secret, code signing, or a runner problem, change nothing and finish blocked with the reason.
  4. Push chamaquita/upstream-v0.1.4-nightly.20261028.3841 and open a pull request into custom-nightly. Its body starts with Closes # and this issue's number, then has a table with one row per conflicted hunk or fix and the columns File:lines, Class, custom-nightly, Upstream, Kept, and Why. If a push is refused for the workflows permission, change nothing and finish blocked with that reason.
  5. Fork CI on the pull request typechecks and builds the desktop app. Chamaquita merges it once that passes, and the next nightly run publishes the build.

Run: https://github.com/d3labs-dev/t3code/actions/runs/40769651509

Activity

  1. added
    chamaquitaChamaquita works this issue as a Job
    automergeChamaquita merges the Job's pull request once its checks pass
    on Oct 28, 2026
  2. chamaquita-d3 commented on Oct 28, 2026

    @chamaquita-d3

    Chamaquita started Attempt 1 of 2 on this issue, stamped by github-actions[bot], the repository's GitHub Actions. automerge stamped by github-actions[bot], the repository's GitHub Actions. Follow it in Discord: https://discord.com/channels/1497356507472466022/1564056102197403689

  3. chamaquita-d3 commented on Oct 28, 2026

    @chamaquita-d3

    Attempt 1 of 2: Claude Code finished, waiting for GitHub CI
    I merged the upstream tag with a real merge commit, so the tag is an ancestor of the branch. The only conflict was two hunks in apps/server/src/settingsSecrets.ts. Both were disjoint, so I kept the fork's dictation and easDeviceHosts and added upstream's simlockDeviceHosts. I took upstream's pnpm-lock.yaml and ran pnpm install --ignore-scripts to reconcile it. tsc --noEmit passes for apps/server, apps/web and packages/contracts, so no further fixes were needed. The branch pushed without a workflows-permission refusal, even though the merge touches two workflow files. PR #189 has the required conflict table. I didn't wait for its fork CI checks.
    Pull request: #189
    Branch: chamaquita/upstream-v0.1.4-nightly.20261028.3841
    Claude Code session: 59986cea-214d-499f-af1a-b4a935729319
    Chamaquita merges it once GitHub CI passes on commit f1463e0. If no check has started by 21:23 UTC, or some still run at 21:43 UTC, a person takes it from there.

    In Discord: https://discord.com/channels/1497356507472466022/1564056102197403689/1565110616384077966

  4. chamaquita-d3 commented on Oct 28, 2026

    @chamaquita-d3

    Attempt 1 of 2 finished: success
    I merged the upstream tag with a real merge commit, so the tag is an ancestor of the branch. The only conflict was two hunks in apps/server/src/settingsSecrets.ts. Both were disjoint, so I kept the fork's dictation and easDeviceHosts and added upstream's simlockDeviceHosts. I took upstream's pnpm-lock.yaml and ran pnpm install --ignore-scripts to reconcile it. tsc --noEmit passes for apps/server, apps/web and packages/contracts, so no further fixes were needed. The branch pushed without a workflows-permission refusal, even though the merge touches two workflow files. PR #189 has the required conflict table. I didn't wait for its fork CI checks.
    Pull request: #189 (merged)
    Branch: chamaquita/upstream-v0.1.4-nightly.20261028.3841
    Claude Code session: 59986cea-214d-499f-af1a-b4a935729319
    GitHub CI passed on commit f1463e0.
    Merged into custom-nightly as merge commit 9257317, because the issue carries automerge and GitHub CI passed.

    In Discord: https://discord.com/channels/1497356507472466022/1564056102197403689/1565110616384077966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    automergeChamaquita merges the Job's pull request once its checks passchamaquitaChamaquita works this issue as a Job

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions