Repository navigation
xrootd: improve handling of prepare options - #8266
Open
DmitryLitvintsev wants to merge 1 commit into
Open
DmitryLitvintsev wants to merge 1 commit into
DmitryLitvintsev wants to merge 1 commit into
Conversation
Motivation: ----------- Prepare evict option is passed via an extra option (optionX) according to the xrootd protool spec and may conflict with main options/actions passed via request options field. Modification: ------------ Improve prepare options hadling. If not options or extra options are specified - just return success. Handle contradicting options. Bump xrootd4j version number to pick up properly extracted kXR_evict option. Result: ------- Better protocol spec adherence. Target: trunk Request: 12.0, 11.2 Patch: https://rb.dcache.org/r/14811/ Acked-by: Tigran Require-book: no Require-notes: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Prepare evict option is passed via an extra option (optionX) according to the xrootd protool spec and may conflict with main options/actions passed via request options field.
Modification:
Improve prepare options hadling. If not options or extra options are specified - just return success. Handle contradicting options.
Bump xrootd4j version number to pick up properly extracted kXR_evict option.
Result:
Better protocol spec adherence.
Target: trunk
Request: 12.0, 11.2
Patch: https://rb.dcache.org/r/14811/
Acked-by: Tigran
Require-book: no
Require-notes: yes