Repository navigation
Conversation
Motivation: Since commit 5021255 ("cells: simplify initialization of LocationManagerConnector") the connector is created without cell arguments. However, those arguments were forwarded to LocationMgrTunnel, which reads the `role` option passed from batch files. Thus, it always fall-backed to SATELLITE. As a result, a core domain that connects to another core domain announces itself as a satellite. The connecting core installs a default route to its peer, and the accepting core allows forwarding of messages received through that tunnel. Messages published to a topic are then delivered by every core domain along the default route chain, e.g. billing records show up two or three times in setups with multiple core domains. Modification: Pass the domain role explicitly to LocationManagerConnector and from there to LocationMgrTunnel through a dedicated constructor, instead of relying on forwarded cell arguments. Add unit test to cover the regression. Result: Core domains no longer install default routes to other core domains and messages sent to a topic are delivered only once. No more duplicate billing records in setups with multiple core domains. Issue: #8008 Acked-by: Marina Sahakyan Target: master, 12.0, 11.2, 11.1, 11.0 Require-book: no Require-notes: yes (cherry picked from commit 3c3ff60) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
kofemann
force-pushed
the
issue8008-11.2
branch
from
October 21, 2026 13:15
9b76234 to
c64a431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Since commit 5021255 ("cells: simplify initialization of LocationManagerConnector") the connector is created without cell arguments. However, those arguments were forwarded to LocationMgrTunnel, which reads the
roleoption passed from batch files. Thus, it always fall-backed to SATELLITE. As a result, a core domain that connects to another core domain announces itself as a satellite. The connecting core installs a default route to its peer, and the accepting core allows forwarding of messages received through that tunnel. Messages published to a topic are then delivered by every core domain along the default route chain, e.g. billing records show up two or three times in setups with multiple core domains.Modification:
Pass the domain role explicitly to LocationManagerConnector and from there to LocationMgrTunnel through a dedicated constructor, instead of relying on forwarded cell arguments. Add unit test to cover the regression.
Result:
Core domains no longer install default routes to other core domains and messages sent to a topic are delivered only once. No more duplicate billing records in setups with multiple core domains.
Issue: #8008
Acked-by: Marina Sahakyan
Target: master, 12.0, 11.2, 11.1, 11.0
Require-book: no
Require-notes: yes
(cherry picked from commit 3c3ff60)