Skip to content

Fix Light LoopExpression dropping ContinueLabel when BreakLabel is null - #575

Merged
dadhi merged 1 commit into
masterfrom
fix-light-loop-continue-label
Nov 2, 2026
Merged

dadhi merged 1 commit into
masterfrom
fix-light-loop-continue-label

Conversation

@dadhi

@dadhi dadhi commented Nov 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

net10.0: Comparison complete (reporting only)

Base e82c9500e629 → PR 6b66ec0e62d9; SDK 10.0.301; harness e82c9500e629 (base).

Backend / phase / workload Base ns PR ns Time change B/op: base → PR Assessment
Light / Compile / Arithmetic 4499.06 4642.64 +3.3% 947.50 → 947.50 Warning / noise
Light / Compile / CallConditional 2527.83 2527.70 +0.4% 1381.50 → 1382.00 Within variation
Light / Compile / Closure 4890.77 4926.91 +1.4% 3040.00 → 3038.50 Within variation
Light / Compile / Scalar 1789.90 1709.46 -4.3% 890.50 → 893.00 Within variation
Light / CompileAndFirstInvoke / Arithmetic 26698.48 26997.80 +1.1% 928.00 → 928.00 Within variation
Light / CompileAndFirstInvoke / CallConditional 30086.31 29680.53 -1.3% 1360.00 → 1360.00 Within variation
Light / CompileAndFirstInvoke / Closure 129689.07 131268.23 +1.2% 3184.00 → 3184.00 Within variation
Light / CompileAndFirstInvoke / Scalar 6226.49 6079.84 -2.3% 872.00 → 872.00 Within variation
Light / Construct / Arithmetic 652.10 641.77 -1.6% 1296.00 → 1296.00 Within variation
Light / Construct / CallConditional 119.95 118.05 -1.5% 360.00 → 360.00 Within variation
Light / Construct / Closure 75.25 73.23 -2.7% 144.00 → 144.00 Within variation
Light / Construct / Scalar 54.49 52.43 -3.7% 120.00 → 120.00 Within variation
Light / Invoke / Arithmetic 1.47 1.62 +11.5% 0.00 → 0.00 Warning / noise
Light / Invoke / CallConditional 2.20 2.23 +1.4% 0.00 → 0.00 Within variation
Light / Invoke / Closure 24.34 23.72 -2.6% 184.00 → 184.00 Within variation
Light / Invoke / Scalar 1.85 1.60 -13.4% 0.00 → 0.00 Improvement
Standard / Compile / Arithmetic 4481.30 4455.67 -0.6% 947.50 → 947.50 Within variation
Standard / Compile / CallConditional 2683.55 2559.42 -4.6% 1380.50 → 1382.00 Within variation
Standard / Compile / Closure 5314.83 4942.22 -7.0% 3040.00 → 3039.50 Within variation
Standard / Compile / Scalar 1778.49 2032.48 +14.2% 889.00 → 891.50 Allocation increase
Standard / CompileAndFirstInvoke / Arithmetic 27071.57 26531.27 -2.0% 928.00 → 928.00 Within variation
Standard / CompileAndFirstInvoke / CallConditional 30234.14 29469.31 -2.5% 1360.00 → 1360.00 Within variation
Standard / CompileAndFirstInvoke / Closure 134099.78 130546.84 -2.5% 3184.00 → 3184.00 Within variation
Standard / CompileAndFirstInvoke / Scalar 6517.64 6362.17 -2.4% 872.00 → 872.00 Within variation
Standard / Construct / Arithmetic 993.19 980.00 -1.3% 1808.00 → 1808.00 Within variation
Standard / Construct / CallConditional 486.36 444.61 -8.2% 736.00 → 680.00 Within variation
Standard / Construct / Closure 238.30 235.20 -1.2% 440.00 → 440.00 Within variation
Standard / Construct / Scalar 181.49 183.86 +1.4% 416.00 → 416.00 Within variation
Standard / Invoke / Arithmetic 1.60 1.42 -9.6% 0.00 → 0.00 Within variation
Standard / Invoke / CallConditional 2.29 2.27 -0.9% 0.00 → 0.00 Within variation
Standard / Invoke / Closure 25.38 24.95 -0.8% 184.00 → 184.00 Within variation
Standard / Invoke / Scalar 1.40 1.38 -1.8% 0.00 → 0.00 Within variation

Two opposite-order process rounds on one GitHub-hosted runner; BDN confidence intervals must be separated in both rounds to classify a >5% time regression. A ≥3% change without that evidence is a warning, not proof. Five measurement iterations/round; hosted-runner noise remains.

Compile excludes delegate invocation; CompileAndFirstInvoke includes the first call/JIT of a new delegate. Invoke is warmed; closure invocation includes creating and calling the returned delegate. MemoryDiagnoser reports managed B/op. Loop/checksum overhead is shared by both revisions.

Workflow run and complete raw artifacts

@dadhi
dadhi merged commit 07cf723 into master Nov 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant