Fix environment creation from shallow clones - #347
Open
cyq1017 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Endorsed for merge.
Minor note: if itself fails, the subsequent push retry will retry the push rather than reattempt unshallowing, but that's acceptable since the unshallow error will still surface. |
Collaborator
|
@cyq1017 friendly ping — this PR currently has merge conflicts with . Could you rebase onto and resolve the conflicts? Once the merge conflicts are gone I'll be happy to re-review. |
cyq1017
force-pushed
the
codex/fix-issue-248-shallow-unshallow
branch
from
August 12, 2026 18:38
9356a55 to
42269bc
Compare
Author
|
Rebased onto the latest main and resolved the conflicts. I reran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #248.
Tests
go test ./repository -run TestInitializeWorktreeUnshallowOnShallowClonego test -short ./...git diff --check