fix(repository): prevent path traversal in exportEnvironmentFile - #365
Merged
Conversation
Strengthens exportEnvironmentFile so the resolved file path cannot escape the worktree root. Adds a filepath.Rel check after filepath.Join and rejects any path that resolves outside the worktree. Based on the bug report in dagger#337
4 tasks
…t test The previous test only asserted that test inputs looked like escaping paths. This change extracts the validation logic into a testable helper and adds focused tests that actually exercise the function.
grouville
self-requested a review
August 12, 2026 16:26
grouville
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337
Strengthens
exportEnvironmentFileso the resolved file path cannot escape the worktree root. Adds afilepath.Relcheck afterfilepath.Join(worktreePath, clean)and rejects any path that resolves outside the worktree.The existing guard rejected
filepath.IsAbsand raw..prefixes; this change also catches cases where a cleaned relative path still resolves above the worktree.Verification:
go build ./...✅go test -short ./repository/... ./environment/... ./mcpserver/... ./cmd/container-use/agent/...✅This branch is based on the current
dagger/container-use:main(0d87ad6) and merges cleanly as a fast-forward.