Repository navigation
feat(ui): watchlist keyed by security, closed-fund badge - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
status: closed,closedDate,closedSourcein index.json) keep their row with aClosed <date>badge that links the closing notice; the Fund Name filter (closed,!closed) and the search find themWhy
ETF-C3: different securities with one ticker became one Watchlist row (WisdomTree N-PORT sheets gave bonds and FX forwards their issuer's equity ticker, fixed on the data side in #87). Q21: closed funds were not visible as closed
Code from the shared blocks
watchlist-key.tsx,closed-badge.tsx,closed.css, ported withsecurities.ts(workspace ui-std), as in Neos daggerok/Neos#71How it was checked
bun test: 65 pass, 0 failbun run build,bun build --target=bun src/main.tsx --outfile=/dev/null,git diff --checktc/check.sh: 52 lines, the same as on main, nothing newdist(headless, silent):brand-uitest.ts: 43 passed, 0 failed; console errors: nonecolumns-uitest.ts: 19 passed, 0 failed; console errors: nonecategories-uitest.ts: 19 passed, 0 failed; console errors: noneclear-uitest.ts: 19 passed, 0 failed; console errors: nonesecurity-uitest.ts: 20 passed, 0 failed; console errors: none