Repository navigation
fix(updater): n-port name key from the shared template 3380d91 - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nport-readerblock from workspace template commit 3380d91 (this repo carried 5999634 since fix(updater): current shared n-port name key (dotted legal abbreviations, public limited company) #89):nportNameKeynow joins every run of single-letter initials whether written with dots, spaces or a slash (N.V.=N V=NV,C.H. ROBINSON= SEC'sC H ROBINSON,A/S=A S), keeps a leadingUS(U.S. BANCORPis no longerBancorp, Inc.= TBBK) and strips backslash EDGAR suffixes (US BANCORP \DE\) as well as the slash ones;PUBLIC LIMITED COMPANYstays plcN-PORT issuer names match SEC titles across initials, a leading US and backslash EDGAR suffixesinparsing 3(US Bancorp -> USB, Bancorp Inc/The -> TBBK, CH Robinson Worldwide Inc -> CHRW); it fails with the 5999634 blockWhy
Issuer names in N-PORT filings and SEC company titles spell initials differently, so U.S. equities could lose their ticker or (U.S. Bancorp) get a wrong one
Effect on real filings
Newest real N-PORT-P filing read with this repo's own
readNportHoldings+nportTickers(published rows 0, as with the fund folder removed), old block vs new block on byte-identical cached SEC answers; nothing written toapi/:No ticker changes for these funds today (the filer gives most tickers itself; in EPS the 33 rows without one are non-U.S. ISINs and money market funds); the change guards future filings
Checks
bun test: 66 pass, 0 fail, exit 0 (one new test); the same with everyupdate-data.config.jsoncontrol exported: 66 pass, exit 0bun build --target=bun scripts/update-data.ts --outfile=/dev/null,bun build --target=bun src/main.tsx --outfile=/dev/null,git diff --checkcheck-readme.ts .,check-scripts.ts .: ok;apply-block.ts --check holdings-guard,nport-reader,windowed-chart,fund-selection .: all identicaltc/check.sh .: no new errors (52 lines, same as main)