Skip to content

feat(storybook): GTA VI award, event achievements and Vice City theme - #7334

Open
tomeredlich wants to merge 8 commits into
mainfrom
claude/gta-vi-awards-achievements-219c21
Open

feat(storybook): GTA VI award, event achievements and Vice City theme#7334
tomeredlich wants to merge 8 commits into
mainfrom
claude/gta-vi-awards-achievements-219c21

Conversation

@tomeredlich

@tomeredlich tomeredlich commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Storybook-only designs for the rest of the GTA VI launch (Nov 19, 2026), following the streak freeze day in #7322. Everything lives in packages/storybook/stories/gta-vi/. Production code is untouched.

Storybook

GTA VI/1. Vice City award

  • A free award that comes first in Give an Award during launch week. It uses the same tile and icon size as every other award, priced Free.
  • The flow is clickable: pick, note, sent. There's also an "after launch week" state where the award is gone from the picker.
  • Received: previews of the award under a comment (production's award count with the featured award) and on the profile's Badges & Awards widget.

GTA VI/2. Event achievements

  • Made It to Vice City: for everyone who opens daily.dev on Nov 19. Its chip says Free.
  • Still Read on GTA VI Day: for readers who also read a post that day. Its chip says Rare, because rarity percentages don't exist on day one. The art shows the GTA VI start screen on the TV and the daily.dev feed on a phone.
  • The Free chip uses text-background-default as its ink so it passes AA at 14px in both themes.
  • The detail modal shows "Unlocked Nov 19, 2026" next to a calendar icon.
  • The shelf is shown at four moments: Nov 19 after a read, Nov 19 before a read, after the day when it was missed (Still Read leaves the shelf), and before Nov 19 (nothing shows).

GTA VI/3. Vice City theme

  • An opt-in theme: dark mode with the release art behind the home page's shortcuts and greeting.
  • It's never applied for the reader. The settings popover's Theme row (ThemeSection) gets a fourth option, VI, after dark, light and auto. Picking another option turns it off. ThemeSection is shared, so the option shows on Settings › Appearance too.
  • The page shows the switch in the popover, the themed home on laptop and phone, and the popover on its own.

GTA VI/4. All states

Award, Achievements and Theme pages. Every state is tagged Production (unchanged), GTA VI (the change) or Proposed (a gap to decide): loading, empty, send failed, free window closed mid-flow, long and missing names, big counts, failed images, and the theme's four choices. Each page ends with device rows: real iframes of GTA VI/Devices at 375, 768, 1280, 1440 and 1920 wide.

GTA VI/5. Build notes

  • The production components and tokens behind each piece.
  • An edge-case matrix: empty, loading, error and validation, overflow.
  • Contrast measured live from the tokens. Every pair passes AA in dark and light.
  • Keyboard and screen-reader flows.
  • Open decisions, each with the simplest fix.

Notes for engineering

  • production/AchievementShelfCard.tsx is production's card plus the event branch, so its diff is the production change. production/GiveAward.tsx draws GiveAwardModal's three screens inline so they sit side by side. production/AwardPreviews.tsx uses production's Award and SummaryCard.
  • The art comes from Agent Smith and sits in gta-vi/assets/. The daily.dev mark on the phone is drawn from logoGeometry.ts. Move the art to the CDN when this is built.

Found in production (not fixed here)

  • AchievementShelfCard's description clamp never applies: tablet:block overrides line-clamp-1.
  • Its image fallback, https://daily.dev/default-achievement.png, returns 404, so a failed image leaves blank art.

Needs a product call

  • The award is free through Nov 25, with no limit on how many you send.
  • Still Read leaves the shelf once the day has passed.
  • "Free" as an achievement chip may read like a price. "Limited" is an alternative.

🤖 Generated with Claude Code

Preview domain

https://claude-gta-vi-awards-achievement.preview.app.daily.dev

@tomeredlich @claude
feat(storybook): GTA VI award, event achievements and Vice City theme
3eaa465 
Storybook-only designs for the GTA VI launch (Nov 19), after the streak
freeze day (#7322):

- GTA VI/1. Vice City award: a free launch-week award first in Give an
  Award, with the pick, note and sent screens.
- GTA VI/2. Event achievements: Made It to Vice City (everyone on release
  day, Free chip) and Still Read on GTA VI Day (read that day, Rare chip),
  on a stand-in of production's AchievementShelfCard, across the days
  around release.
- GTA VI/3. Vice City theme: an opt-in home cover, turned on from a
  one-time nudge or Settings > Appearance, never applied automatically.

Art generated by Agent Smith.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
daily-webapp Ready Ready Preview Nov 10, 2026 4:34pm UTC
storybook Ready Ready Preview Nov 10, 2026 4:34pm UTC

Request Review

@tomeredlich @claude
fix(storybook): use the real daily.dev logo on the GTA VI tablet art
9004b06 
The generated art drew a made-up chevron on the tablet. The mark is now
drawn from logoGeometry's paths, tilted to the tablet's plane, with the
tail at the brand's 64% alpha.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeredlich @claude
feat(storybook): GTA VI theme in the settings popover, award previews
583632f 
- Vice City theme: picked from the settings popover's Theme row, a fourth
  option after dark, light and auto, instead of a home-page nudge and an
  Appearance cover row. The cover art is redone to match the reference
  (hotter sunset, dense skyline, palms, helicopter, car), and the shortcut
  labels sit on a scrim over it.
- Vice City award: the same tile and icon size as every other award, and
  previews of a received award under a comment and on the profile's
  Badges & Awards widget.
- Still Read on GTA VI Day: new art, the console on the TV and the
  daily.dev feed on a phone, with the real logo mark.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tomeredlich and others added 3 commits November 10, 2026 17:27
@tomeredlich @claude
fix(storybook): readable GTA VI award at small sizes, feed thumbnails…
30099f4 
… on the right

The award icon's dark bezel gets lost on the dark page at the 24px comment
size, so it now has a light lavender frame and the scene is cropped tighter
so the VI fills more of it. The phone feed in the Still Read art puts its
thumbnails on the right, with the real logo mark re-stamped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeredlich @claude
fix(storybook): size the GTA VI award like the other awards
b450946 
It filled its whole canvas, so it read bigger than every other award. It now
fills 74% of it, the coffee mug's height, centered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeredlich @claude
fix(storybook): white-outlined VI on the GTA VI award
5655e9d 
The neon-outline VI blurred away at the comment's 24px. Smith redrew it
solid with a thick white outline, same scene; the light frame and the
coffee-mug sizing are reapplied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeredlich @claude
fix(storybook): thinner white outline on the GTA VI award's VI
b3d1dd0 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeredlich @claude
feat(storybook): GTA VI all states, device previews and build notes
339ad1e 
- GTA VI/4. All states: Award, Achievements and Theme pages with every
  state tagged Production, GTA VI or Proposed: loading, empty, errors and
  validation (send failed, free window closed mid-flow), long and missing
  names, big counts, failed images, and the theme's four choices.
- GTA VI/Devices: one case per story, filling its window, loaded by the
  All states pages in real iframes at phone, tablet, laptop, laptop L and
  desktop widths, so media queries and the phone sheet behave as in the app.
- GTA VI/5. Build notes: the production components and tokens per piece,
  an edge-case matrix, contrast measured live from the tokens in both
  themes, keyboard and screen-reader flows, and the open decisions.
- The Free chip's ink is now text-background-default: white on cabbage
  measured 3.81:1 at 14px in dark, and a fixed dark ink fails in light.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – daily-webapp — 339ad1e0 Deployed Nov 10, 2026 by vercel[bot]
View deployment
Preview – storybook — 339ad1e0 Deployed Nov 10, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tomeredlich