Repository navigation
chore: remove post_page_feed feature flag (post page ends at the comments) - #7339
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
post_page_feedfeature flag. The experiment was rolled back, so the post page keeps the control behaviour:false, the page ends at the comments, with no "More for you" feed below them and the post widgets visible at every width.Result: the DoD retention goal was +2.0% (90%) [-1.1, +5.1]. Phase 2 lost phase 1's post-click lift: Any Post Click +0.4% [-1.8, +2.5]. Ad CTR and time on site leaned negative.
Deleted
featurePostPageFeedand the page's evaluation of it (pages/posts/[id]/index.tsx)components/post/feed/PostPageFeed(component, CSS module, spec)belowCommentsslot, which was threaded throughBasePostContent,PostContent,SquadPostContent,SocialTwitterPostContent,PollPostContentandCollectionPostContent, andgetPostWidgetsClassName. Both only served the feed.Feed'sfooteranderrorScreenprops and their specs. The post page feed was their only user.capitalizeprop onSquadDirectoryNavbarItem(no remaining users), and the chip class exports fromUnifiedMobileFeedNavare no longer exported.stories/experiments/PostPageFeed.stories.tsx,stories/experiments/postPageFeed/)webapp/__tests__/PostPage.tsxKept: the
useFeedempty-feed handling forexcludedPostIdsfrom #7018.MainFeedLayoutstill usesexcludedPostIds.Checks
oxlintandoxfmt --checkpass on the touched files insharedandwebapptscpasses inwebapp. Inshared, the only error is the existing unused@ts-expect-errorinarchive/ArchiveFeedPage.spec.tsx, which this PR doesn't touch.sharedFeed.spec,components/post/**, squads layout and feeds nav: 40 suites, 323 tests pass.webapp__tests__/PostPage.tsx: 64 tests pass.post_page_feed,featurePostPageFeed,PostPageFeed,belowCommentsorgetPostWidgetsClassNameremainPrepared by Smith on behalf of @idoshamun.
Preview domain
https://cleanup-post-page-feed.preview.app.daily.dev