Skip to content

Announce column separator - #679

Draft
moritz-gross wants to merge 2 commits into
daisy:mainfrom
moritz-gross:announce-column-separator
Draft

Announce column separator#679
moritz-gross wants to merge 2 commits into
daisy:mainfrom
moritz-gross:announce-column-separator

Conversation

@moritz-gross

Copy link
Copy Markdown
Collaborator

No description provided.

moritz-gross and others added 2 commits August 12, 2026 00:20
…in speech output

- Replace `count_table_dims` return type with `usize` values for clarity.
- Update function registration to include `HasVisibleColumnLine`.
- Modify speech tests to reflect separator usage in matrix descriptions.
@moritz-gross

Copy link
Copy Markdown
Collaborator Author

@NSoiffer some questions:

  • how should we announce the separator? Just as "separator" ?
  • the way add_builtin_functions works is a bit unclear to me. First off, shouldn't it be called something like register_mathcat_xpath_functions, as we register MathCAT-specific XPath functionality? Also, I think it's a bit clunky that these functions need to be attached to an otherwise empty struct each time. Is there no way around that?
  • Isn't the signature cleaner when count_table_dims returns a tuple of usize or i32 etc? idk how I feel about Value<'d> (tbh I need to learn a bit more Rust in the first place to understand what 'd is doing in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant