Point failed uploads to validation report - #1896
Open
AtomicGlance wants to merge 1 commit into
Open
Conversation
AtomicGlance
marked this pull request as ready for review
August 5, 2026 09:56
yarikoptic
requested changes
Aug 6, 2026
yarikoptic
left a comment
Member
There was a problem hiding this comment.
overall looks good. minor nit due to my duplication allergies.
Comment on lines
+481
to
+488
| if validation_log_path is None: | ||
| lgr.warning("One or more assets failed validation.") | ||
| else: | ||
| lgr.warning( | ||
| "One or more assets failed validation. Use" | ||
| " `dandi validate --load %s` to review the saved results.", | ||
| validation_log_path, | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| if validation_log_path is None: | |
| lgr.warning("One or more assets failed validation.") | |
| else: | |
| lgr.warning( | |
| "One or more assets failed validation. Use" | |
| " `dandi validate --load %s` to review the saved results.", | |
| validation_log_path, | |
| ) | |
| msg = "One or more assets failed validation." | |
| if validation_log_path: | |
| msg += f" Use `dandi validate --load "{validation_log_path}"`" \ | |
| " to review the saved results.", | |
| lgr.warning(msg) |
to avoid duplication
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
===========================================
- Coverage 76.96% 53.09% -23.87%
===========================================
Files 88 89 +1
Lines 12882 12901 +19
===========================================
- Hits 9914 6850 -3064
- Misses 2968 6051 +3083
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dandi validate --loadcommandCloses #1859.
Testing
python -m pytest dandi/cli/tests/test_cmd_upload.py -qpython -m mypy dandi(93 source files)