Skip to content

Raise the nwbinspector floor to 0.7.2 for more flexible dependencies specification as relating to zarrs - #1972

Merged
yarikoptic merged 1 commit into
dandi:masterfrom
h-mayorquin:nwbinspector_floor
Oct 29, 2026
Merged

yarikoptic merged 1 commit into
dandi:masterfrom
h-mayorquin:nwbinspector_floor

Conversation

@h-mayorquin

Copy link
Copy Markdown
Contributor

#1971 needs this, as nwbinspector releases before 0.7.2 require hdmf-zarr and on Python 3.11 every hdmf-zarr release either caps zarr < 3 or breaks on import with zarr 3. This PR raises the floor to 0.7.2, the first release where hdmf-zarr is optional. I am separating this from #1971 as it might warrant a separate discussion.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.89%. Comparing base (e65abd3) to head (85d7ee0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
+ Coverage   90.83%   90.89%   +0.06%     
==========================================
  Files          92       92              
  Lines       14190    14190              
==========================================
+ Hits        12889    12898       +9     
+ Misses       1301     1292       -9     
Flag Coverage Δ
unittests 90.89% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Oct 29, 2026
@yarikoptic yarikoptic changed the title Raise the nwbinspector floor to 0.7.2 Raise the nwbinspector floor to 0.7.2 for more flexible dependencies specification as relating to zarrs Oct 29, 2026
@yarikoptic
yarikoptic marked this pull request as ready for review October 29, 2026 17:12
@yarikoptic
yarikoptic merged commit 152e941 into dandi:master Oct 29, 2026
38 of 39 checks passed
@h-mayorquin
h-mayorquin deleted the nwbinspector_floor branch October 29, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants