Repository navigation
fix: fade tab strip edges when tabs overflow - #433
Merged
Merged
Conversation
…ll position valid When the tab row overflows, the edge that hides tabs fades out. Closing tabs no longer leaves the strip scrolled past the end. The SwiftUI fallback strip keeps tabs at a readable minimum width.
… branch or PR Drops the automatic "PR #N" and ticket-id titles so a terminal tab shows its live process title.
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #432, which already added the readable minimum width, mouse-wheel scrolling and reveal of the selected tab.
Testing
testNativePaneTabBarKeepsTitlesReadableAndScrollsSelectedTabIntoView(15 long-titled tabs: minimum width, overflow, selected tab scrolled into view). Updated the panel-title test inWorkspaceUnitTests.Demo Video
Checklist
./scripts/reload.sh --tag <name>)