test: spread masternode-heavy functional tests apart in test_runner.py to fix asan job - #7658
test: spread masternode-heavy functional tests apart in test_runner.py to fix asan job#7658knst wants to merge 1 commit into
Conversation
ASan CI job was OOM-killed [guess, no proof] - https://github.com/dashpay/dash/actions/runs/33900161711/job/101121790181?pr=7646 As tested locally [with no asan]: The first biggest peak 4426 MB PSS / 6123 MB RSS with 37 dashd at 345 s, all 37 belonging to the four named tests with feature_protx_version (15 dashd), feature_llmq_connections (11 dashd), feature_llmq_is_retroactive and feature_asset_locks The second biggest peak is 3935 MB, 34 dashd: during feature_dip3_deterministicmns (13 dashd), feature_llmq_rotation.py (9 dashd), feature_llmq_simplepose (6+6). ----- Moving some masternode functional tests within the list reduces the number of dashd processes that run on the same time with -j4. By simulation [done by Fable 5.1], expected memory peak should be significantly reduced: -j4 3900 → 3124 MB. There's no regression for -j6 5327 → 5300 and -j8 7349 → 7003 [by simulation]
fcaf385 to
7913c0e
Compare
|
✅ Final review complete — no blockers (commit 7913c0e) |
Potential PR merge conflictsThis is advisory only. It does not block CI, but it marks PRs that will likely need a rebase depending on merge order. If this PR merges firstThese open PRs will likely need a rebase:
If these PRs merge firstThis PR will likely need a rebase:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe functional test runner reorders entries in the Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates only the default functional-test execution order to reduce concurrent masternode-heavy workloads. Test coverage remains unchanged, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcaf38568b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — GLM Flash + Sol
At exact head 7913c0e, the PR only reorders selected BASE_SCRIPTS entries, preserves the complete 316-entry multiset without duplicates or missing files, and works with the runner's front-to-back scheduling. Python syntax compilation passed, and no actionable correctness, coverage, or scheduling issues were found.
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: dash-core-commit-history); reviewer 3: gpt-5.6-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-5.6-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-5.6-sol (agent: sol-verifier, role: final-verifier)
Review provenance
- Phase 1 reviewers (GLM Flash):
glm-5.3-flash— general (completed); agentphase1-reviewer,glm-5.3-flash— dash-core-commit-history (completed); agentphase1-reviewer - Fresh verifier (Sol):
gpt-5.6-sol— final-verifier; agentsol-verifier - Phase 2 reviewers (Sol):
gpt-5.6-sol— general (completed); agentphase2-reviewer,gpt-5.6-sol— dash-core-commit-history (completed); agentphase2-reviewer
2 participants
Issue being fixed or feature implemented
ASan CI job was OOM-killed [guess, no proof] - https://github.com/dashpay/dash/actions/runs/33900161711/job/101121790181?pr=7646
As tested locally [with no asan, numbers are estimation because my workstation hardware configuration and CI are not the same anyway]:
The first biggest peak 4426 MB PSS / 6123 MB RSS with 37 dashd at 345 s, all 37 belonging to the four named tests with feature_protx_version (15 dashd), feature_llmq_connections (11 dashd), feature_llmq_is_retroactive and feature_asset_locks
The second biggest peak is 3935 MB, 34 dashd: during feature_dip3_deterministicmns (13 dashd), feature_llmq_rotation.py (9 dashd), 2 instances of feature_llmq_simplepose (6+6).
What was done?
Moving some masternode functional tests within the list reduces the number of dashd processes that run on the same time with -j4.
How Has This Been Tested?
By simulation [done by Fable 5.1], expected memory peak should be significantly reduced: -j4 3900 → 3124 MB.
There's no regression for -j6 5327 → 5300 and -j8 7349 → 7003 [by simulation]
On CI for PR asan job succeed while on develop fails: https://github.com/dashpay/dash/actions/runs/34049601389/job/101534812733
Breaking Changes
N/A
Checklist: