Fix matrix transpose reference construction - #462
Closed
mdhaber wants to merge 2 commits into
Closed
Conversation
Author
|
This is the ai slop version of gh-463, independently written and posted by GPT-6 Atra (medium effort) via Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_test_matrix_transposeconstructs its expected result by passing nested lists of zero-dimensional arrays toasarray, although the standard only requires nested sequences of Python scalars. Construct the expected transpose by stacking the input rows along axis 1. For empty matrices, allocate the transposed shape explicitly with the input dtype and device, sincestackrequires a nonempty sequence. This also preserves both dimensions for empty matrices.Add regression coverage that rejects non-Python-scalar sequence elements in
asarray, covering rectangular matrices, stacks, and empty dimensions.Validation with array-api-strict 2.6.1 on Python 3.14:
--select Fon both changed files andgit diff --checkpass.Fixes #461.