feat(ui): explicit save button on the processing edit page - #109
Merged
Conversation
Edits are no longer patched on every form change: a save/cancel pair appears at the top of the right-hand actions when there are unsaved changes, and useLeaveGuard warns before leaving the page. Covered by a new e2e spec, plus an e2e-warmup Playwright project that walks the heavy dev routes once so Vite finishes optimizing its lazy deps before the specs run.
@data-fair/lib-node 2.12.1 -> 2.13.3 carries the streamed-error-body socket leak fix (data-fair/lib 2ef7764). axios settles a `responseType: 'stream'` request by rejecting without consuming or destroying the body, so every registry 403/404 permanently checked out one of the 8 keepalive sockets of the shared agent. Past 8 of them the api could no longer reach the registry at all and POST /processings hung forever, which surfaced as an unrelated e2e timeout in memory-oom. The worker shares the same call site. The other @data-fair libs are aligned across the four workspaces, and every dependency flagged by npm audit is bumped (16 advisories -> 0), including tar (critical) and nodemailer 8 -> 10, whose only breaking change is requiring node 20+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the auto-PATCH on every form change of the processing edit page with an explicit "Enregistrer" / "Annuler" pair in the right-hand actions panel, guarded against leaving with unsaved changes.
Why: persisting on every keystroke produced noisy writes and a confusing indeterminate progress bar; users expect to control when their edits are saved.
hasDiffcompares the edited model to a snapshot of the last saved state — taken on vjsf's first normalizing emit — so save/cancel only show up for real changese2e-warmupPlaywright project that walks the heavy dev routes once, so Vite's lazy dep re-optimization stops failing a random e2e spec on a cold startchore(deps): data-fair libs bumped, vulnerable transitive deps patchedHeads-up:
nodemailerjumps from^8to^10in the worker — the mail sending path deserves a second look.ui/src/pages/processings/[id]/index.vuenow importsfast-deep-equal, which is declared in no workspacepackage.jsonand only resolves as a hoisted transitive dep. It should be added toui/package.json.