Skip to content

PDP pull fixups: addPieces nonce/payload/metadata + shovel null blocks - #689

Merged
parkan merged 4 commits into
mainfrom
fix/pdp-pull-fixups
Aug 6, 2026
Merged

PDP pull fixups: addPieces nonce/payload/metadata + shovel null blocks#689
parkan merged 4 commits into
mainfrom
fix/pdp-pull-fixups

Conversation

@parkan

@parkan parkan commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

PDP pull fixes stranded on a working branch, never merged after #678. Companion to #688 (content-provider serving v2 piece CIDs) -- together they make the FWSS pull path work end to end.

  • addPieces used a fixed zero nonce (FWSS keys replay on clientNonces[payer][nonce]) and nil metadata (rejected MetadataArrayCountMismatch); now a fresh nonce + per-piece metadata
  • CommPv2 CID was derived from padded size * 127/128 instead of the real CAR bytes; PayloadSize (car.FileSize) is now plumbed through and encoded, with a guard
  • manual sends set the start/end epoch sentinel; added --payload-size
  • shovel pinned to a fork tolerating null blocks in the indexer (revert when upstreamed)

@parkan
parkan merged commit ecc5939 into main Aug 6, 2026
3 checks passed
@parkan
parkan deleted the fix/pdp-pull-fixups branch August 6, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant