Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .nextchanges/bundles/invalid-identifiers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Reject empty, blank, or control-character resource identifiers and incomplete pipeline library paths during bundle validation.

Configs that previously only warned on missing names (for example models and apps) now fail validate. Explicit empty strings for UC parent fields such as catalog_name are rejected; omitted parents still warn.

This file was deleted.

3 changes: 0 additions & 3 deletions acceptance/bundle/resources/catalogs/empty-name/out.test.toml

This file was deleted.

11 changes: 0 additions & 11 deletions acceptance/bundle/resources/catalogs/empty-name/output.txt

This file was deleted.

5 changes: 0 additions & 5 deletions acceptance/bundle/resources/catalogs/empty-name/script

This file was deleted.

9 changes: 0 additions & 9 deletions acceptance/bundle/resources/catalogs/empty-name/test.toml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Empty file.
7 changes: 0 additions & 7 deletions acceptance/bundle/resources/models/empty-name/script

This file was deleted.

4 changes: 0 additions & 4 deletions acceptance/bundle/resources/models/empty-name/test.toml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

>>> [CLI] bundle validate
Error: dashboard display_name is required
at resources.dashboards.my_dashboard
at resources.dashboards.my_dashboard.display_name
in databricks.yml:8:7

Name: test-bundle
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

>>> [CLI] bundle validate
Error: dashboard warehouse_id is required
at resources.dashboards.my_dashboard
at resources.dashboards.my_dashboard.warehouse_id
in databricks.yml:8:7

Name: test-bundle
Expand Down
43 changes: 21 additions & 22 deletions acceptance/bundle/validate/empty_resources/empty_dict/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
}

=== resources.models.rname ===
Warning: required field "name" is not set
at resources.models.rname
Error: model name is required
at resources.models.rname.name
in databricks.yml:6:12

{
Expand All @@ -53,6 +53,10 @@ Warning: required field "name" is not set
}

=== resources.registered_models.rname ===
Error: registered_model name is required
at resources.registered_models.rname.name
in databricks.yml:6:12

{
"registered_models": {
"rname": {}
Expand All @@ -79,11 +83,11 @@ Warning: required field "table_name" is not set
}

=== resources.schemas.rname ===
Warning: required field "catalog_name" is not set
at resources.schemas.rname
Error: schema name is required
at resources.schemas.rname.name
in databricks.yml:6:12

Warning: required field "name" is not set
Warning: required field "catalog_name" is not set
at resources.schemas.rname
in databricks.yml:6:12

Expand All @@ -94,11 +98,11 @@ Warning: required field "name" is not set
}

=== resources.volumes.rname ===
Warning: required field "catalog_name" is not set
at resources.volumes.rname
Error: volume name is required
at resources.volumes.rname.name
in databricks.yml:6:12

Warning: required field "name" is not set
Warning: required field "catalog_name" is not set
at resources.volumes.rname
in databricks.yml:6:12

Expand Down Expand Up @@ -126,11 +130,11 @@ Warning: required field "schema_name" is not set

=== resources.dashboards.rname ===
Error: dashboard display_name is required
at resources.dashboards.rname
at resources.dashboards.rname.display_name
in databricks.yml:6:12

Error: dashboard warehouse_id is required
at resources.dashboards.rname
at resources.dashboards.rname.warehouse_id
in databricks.yml:6:12

{
Expand All @@ -143,15 +147,10 @@ Error: dashboard warehouse_id is required
}

=== resources.apps.rname ===
Warning: required field "name" is not set
at resources.apps.rname
in databricks.yml:6:12

Error: Missing app source code path or git source
Error: app name is required
at resources.apps.rname.name
in databricks.yml:6:12

app resource 'rname' should have either source_code_path or git_source field

{
"apps": {
"rname": {
Expand All @@ -162,7 +161,7 @@ app resource 'rname' should have either source_code_path or git_source field

=== resources.sql_warehouses.rname ===
Error: sql_warehouse name is required
at resources.sql_warehouses.rname
at resources.sql_warehouses.rname.name
in databricks.yml:6:12

{
Expand All @@ -177,8 +176,8 @@ Error: sql_warehouse name is required
}

=== resources.secret_scopes.rname ===
Warning: required field "name" is not set
at resources.secret_scopes.rname
Error: secret_scope name is required
at resources.secret_scopes.rname.name
in databricks.yml:6:12

{
Expand All @@ -188,8 +187,8 @@ Warning: required field "name" is not set
}

=== resources.alerts.rname ===
Warning: required field "display_name" is not set
at resources.alerts.rname
Error: alert display_name is required
at resources.alerts.rname.display_name
in databricks.yml:6:12

Warning: required field "evaluation" is not set
Expand Down
43 changes: 21 additions & 22 deletions acceptance/bundle/validate/empty_resources/with_grants/output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ Warning: unknown field: grants
at resources.models.rname
in databricks.yml:7:7

Warning: required field "name" is not set
at resources.models.rname
Error: model name is required
at resources.models.rname.name
in databricks.yml:7:7

{
Expand All @@ -69,6 +69,10 @@ Warning: unknown field: grants
}

=== resources.registered_models.rname ===
Error: registered_model name is required
at resources.registered_models.rname.name
in databricks.yml:7:7

{
"registered_models": {
"rname": {
Expand Down Expand Up @@ -101,11 +105,11 @@ Warning: required field "table_name" is not set
}

=== resources.schemas.rname ===
Warning: required field "catalog_name" is not set
at resources.schemas.rname
Error: schema name is required
at resources.schemas.rname.name
in databricks.yml:7:7

Warning: required field "name" is not set
Warning: required field "catalog_name" is not set
at resources.schemas.rname
in databricks.yml:7:7

Expand All @@ -118,11 +122,11 @@ Warning: required field "name" is not set
}

=== resources.volumes.rname ===
Warning: required field "catalog_name" is not set
at resources.volumes.rname
Error: volume name is required
at resources.volumes.rname.name
in databricks.yml:7:7

Warning: required field "name" is not set
Warning: required field "catalog_name" is not set
at resources.volumes.rname
in databricks.yml:7:7

Expand Down Expand Up @@ -159,11 +163,11 @@ Warning: unknown field: grants
in databricks.yml:7:7

Error: dashboard display_name is required
at resources.dashboards.rname
at resources.dashboards.rname.display_name
in databricks.yml:7:7

Error: dashboard warehouse_id is required
at resources.dashboards.rname
at resources.dashboards.rname.warehouse_id
in databricks.yml:7:7

{
Expand All @@ -180,15 +184,10 @@ Warning: unknown field: grants
at resources.apps.rname
in databricks.yml:7:7

Warning: required field "name" is not set
at resources.apps.rname
in databricks.yml:7:7

Error: Missing app source code path or git source
Error: app name is required
at resources.apps.rname.name
in databricks.yml:7:7

app resource 'rname' should have either source_code_path or git_source field

{
"apps": {
"rname": {
Expand All @@ -203,7 +202,7 @@ Warning: unknown field: grants
in databricks.yml:7:7

Error: sql_warehouse name is required
at resources.sql_warehouses.rname
at resources.sql_warehouses.rname.name
in databricks.yml:7:7

{
Expand All @@ -222,8 +221,8 @@ Warning: unknown field: grants
at resources.secret_scopes.rname
in databricks.yml:7:7

Warning: required field "name" is not set
at resources.secret_scopes.rname
Error: secret_scope name is required
at resources.secret_scopes.rname.name
in databricks.yml:7:7

{
Expand All @@ -237,8 +236,8 @@ Warning: unknown field: grants
at resources.alerts.rname
in databricks.yml:7:7

Warning: required field "display_name" is not set
at resources.alerts.rname
Error: alert display_name is required
at resources.alerts.rname.display_name
in databricks.yml:7:7

Warning: required field "evaluation" is not set
Expand Down
Loading
Loading