acc: Reproduce that file syncs are done despite failed resource deployments - #6324
Open
janniklasrose wants to merge 2 commits into
Open
acc: Reproduce that file syncs are done despite failed resource deployments#6324janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: dbdb385
Top 2 slowest tests (at least 2 minutes):
|
Setting MSYS_NO_PATHCONV=1 globally in [Env] fixed the leading-slash /Workspace/... arguments passed to `workspace get-status`, but it also disabled Git Bash path conversion for the shebang-resolved .py helpers (update_file.py, read_id.py). On Windows the native python.exe then received the unconverted POSIX path (/c/a/cli/cli/.../update_file.py -> C:\c\a\cli\cli\...), which does not exist, so the test failed only on the windows/direct runner. Scope the env var to the three get-status calls that actually pass a workspace path, leaving the .py helpers with normal path conversion. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reproduce (via an acceptance test) that file syncs happen at the start of a deployment.
In this case, we inject a failure into the resource deployment and observe that a file move operation takes effect regardless of deployment success.
Why
Discovered this behaviour during an investigation on job file deploy-time race condition.
Ideally, file deletion happens after the deployment finishes (and conditional on success)