Repository navigation
Add git provenance to bundle deploy telemetry - #6842
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: efde107
Top 6 slowest tests (at least 2 minutes):
|
atreyadbrx
force-pushed
the
telemetry-bundle-deploy-git
branch
2 times, most recently
from
September 25, 2026 00:33
c911d63 to
cf4dc1a
Compare
atreyadbrx
force-pushed
the
telemetry-bundle-deploy-git
branch
from
October 8, 2026 21:23
cf4dc1a to
0fcdce3
Compare
atreyadbrx
marked this pull request as ready for review
October 22, 2026 00:12
shreyas-goenka
approved these changes
Oct 26, 2026
Populate the new git and from_workspace_folder fields on BundleDeployEvent from b.Config.Bundle.Git and the deploy environment, so a deploy's origin, branch and commit are captured in telemetry. Requires the matching universe proto change to the frontend log. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: atreyadbrx <atreya.misra@databricks.com>
atreyadbrx
force-pushed
the
telemetry-bundle-deploy-git
branch
from
October 30, 2026 00:32
0fcdce3 to
efde107
Compare
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/bundle/telemetry/deploy-git/DMS=: branch ✅ | main (aed6702) ❌ | latest (v1.23.0) ❌main (aed6702): latest (v1.23.0): same output as main (aed6702) |
Collaborator
Integration test reportCommit: 66ed6bc
6 interesting tests: 4 flaky, 2 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds git provenance to the
bundle deploytelemetry event (BundleDeployEvent):git(BundleGitInfo):origin_url,branchandcommit, taken fromb.Config.Bundle.Git. Theload_git_detailsmutator has already resolved these and stripped credentials from the origin URL.from_workspace_folder: true when the CLI runs on DBR with the bundle source under/Workspace/. This is the same check the source-linked deployment preset uses.Why
The deploy telemetry doesn't record which git source a deployment came from. The CLI already resolves this on every deploy and writes it to
metadata.json, and sends it to DMS forexperimental.deployment_historybundles. None of it reaches Lumberjack, so deploys can't be tied to repos or commits at scale.The matching universe proto change has merged: databricks-eng/universe#2674496. This PR should merge only after the Lumberjack schema pipeline has deployed those columns. Until then the new fields are dropped server-side.
Tests
acceptance/bundle/telemetry/deploy-gitdeploys inside agit-repo-initrepo with an origin remote. It asserts thegitblock andfrom_workspace_folderin the recorded/telemetry-extrequest, following the existing per-field telemetry tests (deploy-target-count,deploy-mode).This pull request and its description were written by Isaac.