Skip to content

[Trivial] clarify strict-mode warning error wording #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lennartkats-db wants to merge 4 commits into from
Closed

[Trivial] clarify strict-mode warning error wording #6899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bc549e
Clarify strict-mode warning error wording
lennartkats-db Oct 1, 2026
0440aa8
Merge remote-tracking branch 'origin/main' into fix/strict-mode-warni…
lennartkats-db Oct 1, 2026
ebc2a28
Add changelog for strict-mode wording
lennartkats-db Oct 1, 2026
f7e6a14
Remove changelog for strict-mode wording
lennartkats-db Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acceptance/bundle/validate/secret_scope_invalid_permission_level/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ Workspace:
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default

Found 2 warnings
Error: 2 warnings were found. Warnings are not allowed in strict mode
Error: 2 warnings were found. Warnings are treated as errors in strict mode
4 changes: 2 additions & 2 deletions acceptance/bundle/validate/strict/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Workspace:
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/foo

Found 1 warning
Error: 1 warning was found. Warnings are not allowed in strict mode
Error: 1 warning was found. Warnings are treated as errors in strict mode

Exit code: 1

Expand All @@ -44,6 +44,6 @@ Workspace:
Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/bar

Found 2 warnings
Error: 2 warnings were found. Warnings are not allowed in strict mode
Error: 2 warnings were found. Warnings are treated as errors in strict mode

Exit code: 1
2 changes: 1 addition & 1 deletion cmd/bundle/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Please run this command before deploying to ensure configuration quality.`,
} else {
prefix = fmt.Sprintf("%d warnings were found", numWarnings)
}
return fmt.Errorf("%s. Warnings are not allowed in strict mode", prefix)
return fmt.Errorf("%s. Warnings are treated as errors in strict mode", prefix)
}

return err
Expand Down
Loading