Repository navigation
Run generate-clijson cleanup via dedicated generate-clijson-post task - #6924
Merged
Merged
Conversation
Relocate the post-`genkit update-sdk` cleanup (restore .gitattributes, relocate the tagging scripts, rewrite and format tagging.yml, drop the unused next-changelog.yml, scrub internal proxy URLs from the genkit *.py.lock files) from the generate-clijson Taskfile steps into .codegen.json's toolchain.post_generate, so genkit performs it for every update-sdk caller rather than only `./task generate-clijson`. The SDK-version consistency check stays in the Taskfile for faster feedback when running generate-clijson manually. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 97d5425
Top 3 slowest tests (at least 2 minutes):
|
denik
reviewed
Oct 7, 2026
Instead of running the post-`genkit update-sdk` cleanup from .codegen.json's toolchain.post_generate, keep it in the Taskfile as a dedicated generate-clijson-post task that generate-clijson references at the end. The SDK bumper can then invoke the same cleanup after its own update-sdk run. The cleanup steps (restore .gitattributes, drop next-changelog.yml, relocate the tagging scripts, rewrite and format tagging.yml, scrub internal proxy URLs from the genkit *.py.lock files) and the trailing 'ws' whitespace step all move into the new task. The SDK-version consistency check stays inline in generate-clijson for faster feedback when run manually. Co-authored-by: Isaac <no-reply@databricks.com>
…ate' into janniklasrose/codegen-post-generate
janniklasrose
changed the title
denik
approved these changes
Oct 12, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
SDK bumper will not run task generate-clijson but genkit directly.
why cannot we fix it to run ./task something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human TL;DR: move deterministic post cli.json generation steps into a separate
generate-clijson-postTask. Preparation for SDK auto-bumper which runsgenkitinstead oftask generate-clijson.Changes
Relocate the post-
genkit update-sdkcleanup forgenerate-clijsonout of the step into a separategenerate-clijson-poststep.Why
SDK bumper will not run
task generate-clijsonbutgenkitdirectly. The CLI-specific cleanup can be triggered separately.This pull request and its description were written by Isaac.