Repository navigation
bundle: always error on references to Terraform-only fields - #6937
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 08c1ddf
Top 6 slowest tests (at least 2 minutes):
|
The warning branch of validate.TFOnlyReferences was only reachable with DATABRICKS_BUNDLE_ENGINE=terraform (or bundle.engine: terraform), and such commands fail with the engine removal error anyway. Drop the engine lookup and always report an error. Reject an invalid or removed DATABRICKS_BUNDLE_ENGINE before initialization so the removal error is the first thing users see. bundle.engine: terraform is still reported by validate.ValidateEngine, which runs before TFOnlyReferences. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/tf-cleanup-engine-params
branch
from
October 6, 2026 10:15
7eb7fef to
9706a2d
Compare
denik
force-pushed
the
denik/tf-cleanup-tf-only-refs
branch
from
October 6, 2026 10:15
4e9d99e to
8ab9370
Compare
janniklasrose
approved these changes
Oct 6, 2026
| Error: the Terraform deployment engine has been removed in Databricks CLI v1.20.0 | ||
|
|
||
| Remove the "bundle.engine" setting (or set it to "direct") to deploy with the direct engine; existing Terraform state is migrated automatically. To keep using Terraform, revert to Databricks CLI v1.19.x. | ||
| See https://docs.databricks.com/dev-tools/bundles/direct for details |
Member
There was a problem hiding this comment.
this is awkward since the bundle doesn't contain bundle.engine but TF was forced via the environment variable. Out of scope of this PR but we should fix that anyway
Contributor
Author
There was a problem hiding this comment.
Good point, noted as follow up.
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DATABRICKS_BUNDLE_ENGINE=terraformis now rejected before initialization, so the removal error is the first (and only) thing users see. Previously, a bundle referencing a Terraform-only field printed a warning first. With that, the warning branch of the Terraform-only reference check is unreachable; it now always reports an error.Tests
New case in
acceptance/bundle/resource_deps/tf_path_only_errorfor the env var.This pull request and its description were written by Isaac.