Repository navigation
bundle: pass bundle resource groups to bind/unbind directly - #6947
Merged
Merged
Conversation
The bind, unbind and apps import commands converted the resource group to a Terraform resource type, and phases.Bind/Unbind immediately converted it back. Pass the group straight through and move BindOptions next to phases.Bind. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 5ae4b06
Top 8 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle deployment bind,bundle deployment unbindandapps importconverted the bundle resource group (e.g.jobs) to a Terraform resource type, andphases.Bind/phases.Unbindimmediately converted it back. The mapping is one-to-one, so the round trip was a no-op left over from the terraform engine. Pass the group straight through.Also moves
BindOptionsfrombundle/deploy/terraform/import.go(its only content) next tophases.Bind, withResourceTyperenamed toGroup. The guards that refuse bind/unbind on a terraform state are unchanged.This pull request and its description were written by Isaac.