Skip to content

Fix stale Terraform comments and docs - #6956

Merged
denik merged 1 commit into
mainfrom
denik/tf-cleanup-stale-comments
Oct 7, 2026
Merged

denik merged 1 commit into
mainfrom
denik/tf-cleanup-stale-comments

Conversation

@denik

@denik denik commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Fix comments and docs left stale by the Terraform engine removal. No behaviour change.

  • terraform_dabs_map, dresources/catalog, state_push, Bundle.Terraform (deprecated), telemetry proto comments
  • bundle deployment migrate: comment on the engine env var, and the "no existing state" message no longer tells users to opt into direct (two goldens updated)
  • selection tool example no longer uses the removed engine-matrix level
  • docs/direct.md: migration backs up the remote state and renames the local tfstate; destroy removes all local state including the backup
  • checkPlanOnTempState doc clarified; the code matches it (error is returned and fails the migration), so no code bug

Skipped: schema/python models (Bundle.Terraform is not in the schema, nothing to regenerate).

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the DABs DABs related issues label Oct 6, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 2167d67

Run: 37542436875

Env ✅​pass 🙈​skip Time
✅​ aws linux 276 18 6:06
✅​ aws windows 278 16 5:34
✅​ azure linux 275 18 5:49
✅​ azure windows 277 16 5:13
✅​ gcp linux 276 18 6:05
✅​ gcp windows 278 16 6:20
Top 6 slowest tests (at least 2 minutes):
duration env testname
3:54 azure linux TestAccept
3:51 gcp linux TestAccept
3:51 aws linux TestAccept
3:08 azure windows TestAccept
3:06 gcp windows TestAccept
3:06 aws windows TestAccept

@denik
denik marked this pull request as ready for review October 7, 2026 06:40
@denik
denik requested review from a team as code owners October 7, 2026 06:40
@denik
denik added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit 903951b Oct 7, 2026
25 checks passed
@denik
denik deleted the denik/tf-cleanup-stale-comments branch October 7, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants