Repository navigation
Keep state for a bound resource whose update fails under DMS - #7061
Closed
shreyas-goenka wants to merge 1 commit into
Closed
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
When a BindAndUpdate's update call fails before any state is saved, record the resource's remote state instead. The service rejects a failed BIND_AND_UPDATE operation without state (it acts on a resource that exists), which left the job unrecorded and made the next deploy create a duplicate. With the baseline recorded, the next deploy updates the bound job as expected. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 7b91e70
Top 8 slowest tests (at least 2 minutes):
|
Contributor
Author
|
Superseded by stack #7114; bind-and-update was dropped, so this failure handling is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a bind-and-update's update call fails, record the resource's remote state instead of nothing. DMS rejects a failed
BIND_AND_UPDATEwithout state, which left the job unrecorded and made the next deploy create a duplicate; the extendedrecord-op-faulttest covers this.This pull request and its description were written by Isaac.