Repository navigation
acc: fix empty entries in ENVFILTER filters, enable makezero - #7080
Merged
Merged
Conversation
getEnvFilters created the result with make([]string, len(filters)) and then appended to it, so the filter list started with len(filters) empty strings. Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
October 15, 2026 16:59
denik
enabled auto-merge
October 15, 2026 17:00
Collaborator
Integration test reportCommit: 46e835f
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 15, 2026
Collaborator
Integration test reportCommit: 1f5c6ee
26 interesting tests: 19 FAIL, 7 flaky
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
Integration test reportCommit: 1f5c6ee
56 interesting tests: 54 FAIL, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix
getEnvFiltersin the acceptance runner: it created the slice withmake([]string, len(filters))and then appended, so the filter list began withlen(filters)empty strings. Also enablemakezero, which flags this pattern; this was its only finding.Why
The empty entries were harmless to matching (
MatchesFiltersignores an empty key), but they were a real bug and padded the "does not match filters" skip message.Tests
Ran
ENVFILTER=DMS=true go test ./acceptance -run TestAccept/bundle/deploy/empty-bundle: theDMS=variants are skipped, theDMS=truevariants pass, and the skip message lists onlyDMS=true. golangci-lint reports 0 issues.This pull request and its description were written by Isaac.